Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite/command api #696

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Rewrite/command api #696

wants to merge 44 commits into from

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented Aug 20, 2024 •
edited
Loading

Describe in detail what your pull request accomplishes

Adds new command API using aikar's ACF

Related issues:

Fixes #655

Todo

  • MovecraftCommand rewrite
  • CraftInfoCommand rewrite
  • CraftReportCommand rewrite
  • CraftTypeCommand rewrite
  • CruiseCommand rewrite
  • ManOverboardCommand rewrite
  • PilotCommand rewrite
  • ReleaseCommand rewrite
  • RotateCommand rewrite
  • ScuttleCommand rewrite
  • Add locales for custom no permission & unknown command (Out of scope)

Checklist

  • Tested

@Intybyte
Copy link
Contributor Author

I will wait for someone to do proper testing before continuing because I did about 50% of the taskboard

TylerS1066
TylerS1066 requested changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@TylerS1066 TylerS1066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, and I see a lot of benefits of this framework.

Movecraft/build.gradle.kts Show resolved Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/Movecraft.java Outdated Show resolved Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/commands/MovecraftCommandManager.java Outdated Show resolved Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/commands/MovecraftCommandManager.java Outdated Show resolved Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/commands/CraftInfoCommand.java Outdated Show resolved Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/commands/CraftReportCommand.java Outdated Show resolved Hide resolved
@TylerS1066 TylerS1066 linked an issue Aug 25, 2024 that may be closed by this pull request
New command API #655
Open
@Intybyte Intybyte requested a review from TylerS1066 September 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerToaster98 DerToaster98 DerToaster98 left review comments

@TylerS1066 TylerS1066 Awaiting requested review from TylerS1066

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command API
3 participants
@Intybyte @TylerS1066 @DerToaster98